Whoops ! super is not runtime

super is resolved at compile time. This becomes a problem if you use a class to store methods that you add at runtime to other classes : [super someMethod] will then fail or work by coincidence.

In JSCocoa, each ObjC class written in Javascript can hold arbitrary Javascript data. An NSButton-based class can hold random data without having to declare instance variables, storing variables within a Javascript hash held by the class. To clean that hash, JSCocoa overloads dealloc by calling class_addMethod with the address of deallocAndCleanupJS, the JSCocoa cleanup method.

deallocAndCleanupJS is stored in an NSObject-based class. And super is resolved at compile time. You can see where this goes : in an NSButton-based class, [super dealloc] calls dealloc from NSObject rather than from NSButton. Which is bad.

	// Source class for helper methods, derived from NSObject
	@implementation JSCocoaMethodHolder
	- (void)deallocAndCleanupJS
		// Do Javascript cleanup here
		// Call parent dealloc -> Here this will ALWAYS call NSObject's dealloc
		[super dealloc]
	// Define a new NSObject-based Class in JSCocoa
	defineClass('ApplicationController < NSObject', ...)
	// NSObject → ApplicationController
	// ApplicationController's dealloc will call NSObject dealloc — that's what we want but it's a coincidence ! :)
	// Define a new NSButton-based Class in JSCocoa
	defineClass('MyButton < NSButton', ...)
	// NSObject → NSButton → MyButton
	// MyButton's dealloc will call NSObject dealloc instead of NSButton dealloc — that's a bug !

To call the correct method, we need to switch from a compile time super call to a runtime super call :

	// Compile time super call - INCORRECT
	[super dealloc];

	// Runtime super call - CORRECT !
	struct objc_super s = { self, [self superclass] };
	objc_msgSendSuper(&s, @selector(dealloc));
MyButton will then correctly call the the NSButton dealloc method. As super is not runtime, use objc_msgSendSuper for a runtime super call.

Follow me on Twitter
Planet Cocoa

2011 02 22Distance field
2010 07 202Binding through NSApp
2010 05 122Forwarding invocations
2010 02 272Core Image black fringes
2010 02 21Quickest Way to Shell
2010 02 08Who's calling ?
2009 09 2138 ways to use Blocks in Snow Leopard
2009 08 182Bracket Mess
2009 08 124Taming JavascriptCore within and without WebView
2009 04 15Debugging with Activity Monitor
2009 03 25How Core Image Color Tracking works
2009 03 1510Custom NSThemeFrame
2009 03 10Which framework is running ?
2009 03 074CoreUI can paint pretty big
2009 02 18Localization with functions
2009 01 30Did you forget to nest alloc and init?
2009 01 16JSCocoa on the iPhone
2009 01 11Mixing WebView and JavascriptCore
2009 01 09Badge overflow
2009 01 09Find your Garbage Collection leaks with Instruments

Powered by MediaWiki